Skip to content

28-refactor-handle-exceptions-better#29

Merged
yabjames merged 3 commits intomainfrom
28-refactor-handle-exceptions-better
Dec 15, 2025
Merged

28-refactor-handle-exceptions-better#29
yabjames merged 3 commits intomainfrom
28-refactor-handle-exceptions-better

Conversation

@yabjames
Copy link
Copy Markdown
Owner

@yabjames yabjames commented Dec 15, 2025

  • Replace exit() with exceptions to allow for proper memory deallocation, stack unwinding, destructors to work accordingly

@yabjames
Comment out logging information
5ce69d6
@yabjames
Fix an issue where the program attempts to run a null function pointer
49dc3f1
@yabjames
Throw exceptions and propagate to main.cpp so that memory can be prop…
8c8b9d4 
…erly handled after errors

A std::exit() terminates the whole application, which is bad for a library. It would prevent RAII, destructors, and stack unwinding. Throwing exceptions allows fixes this issue.
@yabjames yabjames linked an issue Dec 15, 2025 that may be closed by this pull request
[REFACTOR] Handle exceptions better #28
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 15, 2025

LCOV of commit 8c8b9d4 during server_workflows.yml #12

Summary coverage rate:
  lines......: 76.3% (1005 of 1317 lines)
  functions..: 86.1% (512 of 595 functions)
  branches...: no data found

Files changed coverage rate: n/a

@yabjames yabjames merged commit f5da2d1 into main Dec 15, 2025
1 check passed
@yabjames yabjames deleted the 28-refactor-handle-exceptions-better branch December 15, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[REFACTOR] Handle exceptions better

1 participant

@yabjames